Skip to content

🎨 Study home page and more improvements #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 25, 2023
Merged

🎨 Study home page and more improvements #4539

merged 20 commits into from
Jul 25, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 24, 2023 •
edited
Loading

What do these changes do?

  • Rearrange items:
    • main column for thumbnail explorer and description
    • secondary column for the rest of the metadata
  • Remove empty project button from S4L product
  • Comments: my comments are right aligned
  • Add texts to restore, maximize and reload iframe buttons
  • Fix: Study Id -> Template Id
  • Fix s4l e2e
  • Fix Merged Large view

Study home page: items rearranged
image

My comments aligned to the right
image

Add texts to restore, maximize and reload iframe buttons
image

Related issue/s

related to ITISFoundation/osparc-issues#979
related to ITISFoundation/osparc-issues#825

How to test

DevOps Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jul 24, 2023
@odeimaiz odeimaiz added this to the Sundae milestone Jul 24, 2023
@odeimaiz odeimaiz self-assigned this Jul 24, 2023
@odeimaiz odeimaiz changed the title WIP 🎨 Study home improvements WIP 🎨 Study home and more improvements Jul 24, 2023
@odeimaiz odeimaiz marked this pull request as ready for review July 25, 2023 09:01
@odeimaiz odeimaiz changed the title WIP 🎨 Study home and more improvements 🎨 Study home and more improvements Jul 25, 2023
@odeimaiz odeimaiz changed the title 🎨 Study home and more improvements 🎨 Study home page and more improvements Jul 25, 2023
@odeimaiz odeimaiz enabled auto-merge (squash) July 25, 2023 09:01
pcrespov
pcrespov reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2023

Code Climate has analyzed commit 2699bb6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

elisabettai
elisabettai approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All very neat, thanks!

I would change iframe "Restore" to "Minimize". Minimize is less ambiguous and goes nicely with "Maximize".

@odeimaiz odeimaiz merged commit 5a7c6e5 into ITISFoundation:master Jul 25, 2023
@odeimaiz
Copy link
Member Author

I would change iframe "Restore" to "Minimize". Minimize is less ambiguous and goes nicely with "Maximize".

I will name it minimize when we implement the minimize feature (also requested by Erdem), for now that buttons restores the iframe.

@sanderegg sanderegg mentioned this pull request Aug 15, 2023
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
Closed
50 tasks
@odeimaiz odeimaiz deleted the feat/improve-home-page branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@elisabettai elisabettai elisabettai approved these changes

@sanderegg sanderegg sanderegg approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@GitHK GitHK Awaiting requested review from GitHK

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Sundae
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @elisabettai @pcrespov @sanderegg